Skip to content

fix: tabIndex focusable, Pressability responder disabled, hover-out timer#56524

Closed
gmacmaster wants to merge 1 commit into
react:mainfrom
Virtual-Fulfillment-Technologies-Inc:port-fixes-from-rnw
Closed

fix: tabIndex focusable, Pressability responder disabled, hover-out timer#56524
gmacmaster wants to merge 1 commit into
react:mainfrom
Virtual-Fulfillment-Technologies-Inc:port-fixes-from-rnw

Conversation

@gmacmaster

@gmacmaster gmacmaster commented Apr 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Summary:

The changes correct tabIndex-to-focusable mapping in View.js, fix a dead null-coalescing branch in the responder disabled check, and fix a hover-out timeout being stored in the wrong variable (_hoverInDelayTimeout instead of _hoverOutDelayTimeout).

Changelog:

Fixed

  • View: Derive focusable from tabIndex with tabIndex >= 0 so positive tabIndex values (e.g. 1, 2) correctly mark the view as focusable; the previous !tabIndex logic treated any positive index as not focusable.
  • Pressability: Use disabled !== true for onStartShouldSetResponder so disabled handling matches onPress and avoids the misleading !disabled ?? true pattern (the ?? true branch was unreachable).
  • Pressability: Store delayed onHoverOut timers on _hoverOutDelayTimeout instead of _hoverInDelayTimeout so hover-out delays are cancelled correctly.

Pick one each for the category and type tags:

[GENERAL] [FIXED] - Fix View tabIndex→focusable mapping and Pressability disabled/hover-out bugs

Test Plan

Not needed

@meta-cla

meta-cla Bot commented Apr 21, 2026

Copy link
Copy Markdown

Hi @gmacmaster!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@gmacmaster gmacmaster mentioned this pull request Apr 21, 2026
Closed
@gmacmaster

gmacmaster commented Apr 21, 2026

Copy link
Copy Markdown
Author

Hi @gmacmaster!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Just signed

@gmacmaster gmacmaster marked this pull request as draft April 21, 2026 01:13
@meta-cla

meta-cla Bot commented Apr 21, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 21, 2026
@gmacmaster gmacmaster closed this Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gmacmaster